>>>>> "Jeff" == Jeff Garzik <jgarzik@xxxxxxxxxxxxxxxx> writes:
Jeff> Jes Sorensen wrote:
>> >>>>> "Jeff" == Jeff Garzik <jgarzik@xxxxxxxxxxxxxxxx> writes:
Jeff> Does ethtool need to be updated for you?
>> A little, it needs to be taught about the tuning parameters for the
>> AceNIC. We probably should put a list of NIC specific tuning items
>> in there so it knows how to grog the different cards' different
Jeff> If they are NIC-specific, then you should just use ioctls...
Jeff> It's a silly redirection to add NIC-specific stuff to the
Jeff> ethtool ioctl, when you could just add a private ioctl.
And another tool to access it so we end up with ethtool and acetool
and sktool and hmetool and 3c905tool etc etc. all of them basically
doing the same thing. It seems silly to have two tools, one for
setting the link rate and flow control and one for setting the
interrupt coalescing counters.
The point is that a lot of the NICs have the same type of tuning
variables, sometimes they are identical sometimes they are slightly
different. My suggestion is that we either teach ethtool about the
different names of tuning parameters or if we are lazy just allow one
to set `NIC private parameters 1-16 with it' and define those for the
different NIC as different things.