> 2. Part two: source address selection for our probes
> - semantic: "in our probes announce the preferred source address for
> the target if the original route in the skb is marked noarp"
I consider it superfluous, and I don't see any symmetry here :-)
If you maintain the proper configuration, i.e. specify preferred source for
output routes, you should be fine.
> Sometimes we don't want to announce particular addresses, for
> example, if they are marked hidden/noarp in local routes - the symmetry.
> In this case we add noarp route and then fallback to the preferred
> source address no matter it is marked as hidden. The RTCF_NOARP flag
> in the output routes is checked in this case (arp_solicit):
> ip rule from ...
> ip route add ... noarp
> Andrey, I see that in your current route.generic version
> arp_solicit always fallbacks to the preferred source address to the
As I've said that code wasn't completely correct.
For the remaining of your code and RTCF_NOARP additions look fine for me.