netdev
[Top] [All Lists]

Re: [PATCHSET] Mobile IPv6 for 2.5.43

To: vnuorval@xxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCHSET] Mobile IPv6 for 2.5.43
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Fri, 18 Oct 2002 09:56:48 +0900 (JST)
Cc: ajtuomin@xxxxxxxxxxxxxxxxxxx, davem@xxxxxxxxxx, kuznet@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, pekkas@xxxxxxxxxx, torvalds@xxxxxxxxxxxxx, jagana@xxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to: <Pine.GSO.4.44.0210180158330.18554-100000@xxxxxxxxxxxxxxxxxxx>
Organization: USAGI Project
References: <20021018.021802.87011078.yoshfuji@xxxxxxxxxxxxxx> <Pine.GSO.4.44.0210180158330.18554-100000@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
In article <Pine.GSO.4.44.0210180158330.18554-100000@xxxxxxxxxxxxxxxxxxx> (at 
Fri, 18 Oct 2002 02:52:48 +0300 (EEST)), Ville Nuorvala 
<vnuorval@xxxxxxxxxxxxxxxxxxx> says:

> >   2. Please put outer address to hardware address in dev.
> 
> The reason I haven't done this is that MAX_ADDR_LEN is just 8. Does anyone
> have any objections against changing the value to 16?
> 
> >      Note: you need to modify SIOxxx ioctls too not to overrun!
> 
> Sorry, I'm not that familiar with ioctls, I just copied the basic
> functionality from sit.c. Could you explain it a bit more thoroughly, so
> even I with my thick skull understand what the problem is?

in net/core/dev.c, there're codes to copy between dev->dev_{addr,broadcast}
and ifr_hwaddr.sa_data (points sockaddr{} sized 16).

Well, we have code for it. :-)
Please look at 
   
<http://www2.linux-ipv6.org/cvsweb/usagi/kernel/linux24/net/core/dev.c.diff?r1=1.1.1.12&r2=1.4>


BTW, why don't we have SIOCGIFHWBROADCAST??

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@xxxxxxxxxxxxxx>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA


<Prev in Thread] Current Thread [Next in Thread>