netdev
[Top] [All Lists]

Re: e100 in net-drivers-2.5-exp

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: e100 in net-drivers-2.5-exp
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Tue, 16 Dec 2003 17:36:20 -0500
Cc: "Feldman, Scott" <scott.feldman@xxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20031216104326.70809423.shemminger@xxxxxxxx>
References: <20031216104326.70809423.shemminger@xxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703
Stephen Hemminger wrote:
e100 in net-drivers-2.5-exp won't compile as a module.

Don't think the new module_param() works the way it is being used
in the new e100 driver.

  CC [M]  drivers/net/e100.o
drivers/net/e100.c:170: error: parse error before "int"
drivers/net/e100.c:170: warning: type defaults to `int' in declaration of 
`module_param'
drivers/net/e100.c:170: warning: function declaration isn't a prototype
drivers/net/e100.c:170: warning: data definition has no type or storage class

Thanks, just checked in the attached patch to fix this.
===== drivers/net/e100.c 1.2 vs edited =====
--- 1.2/drivers/net/e100.c      Tue Dec  9 15:38:42 2003
+++ edited/drivers/net/e100.c   Tue Dec 16 17:35:12 2003
@@ -136,6 +136,7 @@
 
 #include <linux/config.h>
 #include <linux/module.h>
+#include <linux/moduleparam.h>
 #include <linux/kernel.h>
 #include <linux/types.h>
 #include <linux/slab.h>
<Prev in Thread] Current Thread [Next in Thread>