netdev
[Top] [All Lists]

Re: [PATCH] Improve behaviour of Netlink Sockets

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] Improve behaviour of Netlink Sockets
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Tue, 28 Sep 2004 16:20:31 -0700
Cc: pablo@xxxxxxxxxxx, hadi@xxxxxxxxxx, davem@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040928231906.GA25293@xxxxxxxxxxxxxxxxxxx>
References: <1096289189.1075.37.camel@xxxxxxxxxxxxxxxx> <20040927213607.GD7243@xxxxxxxxxxxxxxxxxxx> <1096339407.8660.33.camel@xxxxxxxxxxxxxxxx> <20040928024614.GA9911@xxxxxxxxxxxxxxxxxxx> <1096340772.8659.51.camel@xxxxxxxxxxxxxxxx> <20040928032321.GB10116@xxxxxxxxxxxxxxxxxxx> <1096343125.8661.96.camel@xxxxxxxxxxxxxxxx> <20040928035921.GA10675@xxxxxxxxxxxxxxxxxxx> <1096367787.8662.146.camel@xxxxxxxxxxxxxxxx> <4159D278.4060809@xxxxxxxxxxx> <20040928231906.GA25293@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 29 Sep 2004 09:19:06 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> > ===== net/netlink/af_netlink.c 1.58 vs edited =====
> > --- 1.58/net/netlink/af_netlink.c   Sat Sep 25 17:43:43 2004
> > +++ edited/net/netlink/af_netlink.c Tue Sep 28 22:23:44 2004
> > @@ -475,7 +475,7 @@
> >     if (nlk->handler)
> >             return 0;
> >  #endif
> > -   if (atomic_read(&sk->sk_rmem_alloc) > sk->sk_rcvbuf ||
> > +   if (atomic_read(&sk->sk_rmem_alloc) + skb->len > sk->sk_rcvbuf ||
> 
> I don't see the point of this patch.  All it does is make the overrun
> happen one packet earlier.

That's my sentiment as well.

<Prev in Thread] Current Thread [Next in Thread>