On Wed, 29 Sep 2004, Andi Kleen wrote:
> I'm afraid I must report it's still not completely solved for me yet.
> 10s netperf with TSO on with your patches gives now ~10MB/s less than
> with TSO off (57 vs 67). It's better than before, but not really
> fixed yet.
> Looking at my tcpdumps and comparing TSO on/off I see a quite
> strange effect. It only acks on every ~25th packet with TSO off
> but every ~16th packet with TSO on.
> Receiver is a 2.6.5 kernel, it's weird that it violates the
> ack every two MSS rule.
Does this help?
===== net/ipv4/tcp_input.c 1.73 vs edited =====
--- 1.73/net/ipv4/tcp_input.c 2004-09-12 20:30:58 -04:00
+++ edited/net/ipv4/tcp_input.c 2004-09-28 23:23:40 -04:00
@@ -3936,7 +4048,7 @@
/* ... and right edge of window advances far enough.
* (tcp_recvmsg() will send ACK otherwise). Or...
- && __tcp_select_window(sk) >= tp->rcv_wnd) ||
+ /* && __tcp_select_window(sk) >= tp->rcv_wnd */) ||
/* We ACK each frame or... */
/* We have out of order data. */