netdev
[Top] [All Lists]

Re: bad TSO performance in 2.6.9-rc2-BK

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: bad TSO performance in 2.6.9-rc2-BK
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 30 Sep 2004 10:05:15 +1000
Cc: Andi Kleen <ak@xxxxxxx>, niv@xxxxxxxxxx, jheffner@xxxxxxx, andy.grover@xxxxxxxxx, anton@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040929162923.796d142e.davem@xxxxxxxxxxxxx>
References: <Pine.NEB.4.33.0409291648560.3434-100000@xxxxxxxxxxxxxx> <415B24C0.2020208@xxxxxxxxxx> <20040929145050.71afa1ac.davem@xxxxxxxxxxxxx> <20040929215613.GC26714@xxxxxxxxxxxxx> <20040929162923.796d142e.davem@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Wed, Sep 29, 2004 at 04:29:23PM -0700, David S. Miller wrote:
>
> @@ -567,12 +567,18 @@
>       }
>  
>       skb->ip_summed = CHECKSUM_HW;
> +
> +     /* Any change of skb->len requires recalculation of tso
> +      * factor and mss.
> +      */
> +     tcp_set_skb_tso_factor(skb, tp->mss_cache_std);

Minor optimsations: __tcp_trim_head is only called directly when
tso_factor has already been adjusted by tcp_tso_acked.  So you can
move this setting into tcp_trim_head.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>