|To:||Michael Chan <mchan@xxxxxxxxxxxx>|
|Subject:||Re: [PATCH 2.6.11 3/8] tg3: Add msi support for 5750 C0|
|From:||Jeff Garzik <jgarzik@xxxxxxxxx>|
|Date:||Tue, 22 Mar 2005 15:56:25 -0500|
|Cc:||"David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx|
|User-agent:||Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922|
Michael Chan wrote:
Add MSI support for 5750 C0 and newer chips. MSI is handled by a new interrupt service routine that is very similar to the existing tg3_interrupt() for INTx mode. The MSI version is optimized by not checking for shared interrupt and not flushing the status block. The code is also changed to reference the irq from tp->pdev->irq instead of dev->irq. Signed-off-by: Michael Chan <mchan@xxxxxxxxxxxx
I would prefer that a new 'static inline' function was created, containing the core interrupt handler code.
This avoids the code duplication you have in this patch, in new function tg3_msi().
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: [PATCH 2.6.11 2/8] tg3: flush status block in tg3_interrupt, Jeff Garzik|
|Next by Date:||Re: [PATCH 2.6.11 4/8] tg3: Add msi test, Jeff Garzik|
|Previous by Thread:||[PATCH 2.6.11 3/8] tg3: Add msi support for 5750 C0, Michael Chan|
|Next by Thread:||RE: [PATCH 2.6.11 3/8] tg3: Add msi support for 5750 C0, Michael Chan|
|Indexes:||[Date] [Thread] [Top] [All Lists]|