netdev
[Top] [All Lists]

Re: Fw: [Bugme-new] [Bug 4381] New: When i try to start a pppoe conn., c

To: kaber@xxxxxxxxx (Patrick McHardy)
Subject: Re: Fw: [Bugme-new] [Bug 4381] New: When i try to start a pppoe conn., crash at net/core/skbuff.c:91
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 23 Mar 2005 13:49:01 +1100
Cc: akpm@xxxxxxxx, netdev@xxxxxxxxxxx, o.cornu@xxxxxxxxx, paulus@xxxxxxxxx
In-reply-to: <4240D266.4080403@xxxxxxxxx>
Organization: Core
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686))
Patrick McHardy <kaber@xxxxxxxxx> wrote:
> 
> ===== drivers/net/ppp_async.c 1.26 vs edited =====
> --- 1.26/drivers/net/ppp_async.c        2005-01-21 06:02:12 +01:00
> +++ edited/drivers/net/ppp_async.c      2005-03-23 03:15:31 +01:00
> @@ -183,6 +183,7 @@
>        ap->chan.private = ap;
>        ap->chan.ops = &async_ops;
>        ap->chan.mtu = PPP_MRU;
> +       ap->chan.hdrlen = 2;
>        err = ppp_register_channel(&ap->chan);

I'm not sure whether this could cause the original crash that we saw.
If ap->chan.hdrlen is not set then it should be zero.  It being zero
should not cause skb_over_panic to trigger in ppp_write, should it?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>