netdev
[Top] [All Lists]

Re: Fw: [Bugme-new] [Bug 4381] New: When i try to start a pppoe conn., c

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: Fw: [Bugme-new] [Bug 4381] New: When i try to start a pppoe conn., crash at net/core/skbuff.c:91
From: Paul Mackerras <paulus@xxxxxxxxx>
Date: Wed, 23 Mar 2005 14:06:51 +1100
Cc: Andrew Morton <akpm@xxxxxxxx>, netdev@xxxxxxxxxxx, o.cornu@xxxxxxxxx
In-reply-to: <4240D266.4080403@xxxxxxxxx>
References: <20050321201150.39ba3467.akpm@xxxxxxxx> <4240D266.4080403@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Patrick McHardy writes:

> Looks like hdrlen is uninitialized in ppp_async. This patch

No, it is initialized by the memset at line 165, and 0 is the correct
value for ap->chan.hdrlen, since the ppp_async driver doesn't prepend
any bytes to the skb on transmit.  The bug must be somewhere else.  It
would be very interesting to know what value pf->hdrlen has in
ppp_write and how it got that value though.

Paul.

<Prev in Thread] Current Thread [Next in Thread>