netdev
[Top] [All Lists]

Re: [PATCH] rtnl_unlock/lock in sch_api.c

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: [PATCH] rtnl_unlock/lock in sch_api.c
From: "Catalin(ux aka Dino) BOIE" <util@xxxxxxxxxxxxxxx>
Date: Tue, 29 Mar 2005 01:27:07 +0300 (EEST)
Cc: netdev@xxxxxxxxxxx, davem@xxxxxxxxxxxxx
In-reply-to: <20050328144701.GA3086@xxxxxxxxxxxxxx>
References: <Pine.LNX.4.62.0503281720430.20453@xxxxxxxxxxxxxxxxxxx> <20050328144701.GA3086@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 28 Mar 2005, Thomas Graf wrote:

Looks good, except...
+                               err = -EAGAIN;

You're missing a goto err_out here, the ops == NULL won't catch it.

+                       }
                }
        }
 #endif

-       err = -EINVAL;
        if (ops == NULL)
                goto err_out;

With the above goto inserted there is no need to move the err = -EINVAL.

Thanks, Thomas.

You are right.

I'm redoind the patch right now.

---
Catalin(ux aka Dino) BOIE
catab at deuroconsult.ro
http://kernel.umbrella.ro/

<Prev in Thread] Current Thread [Next in Thread>