|To:||Grant Grundler <grundler@xxxxxxxxxxxxxxxx>, akpm@xxxxxxxx|
|Subject:||Re: patch tulip-natsemi-dp83840a-phy-fix.patch added to -mm tree|
|From:||Jeff Garzik <jgarzik@xxxxxxxxx>|
|Date:||Fri, 20 May 2005 14:58:58 -0400|
|Cc:||T-Bone@xxxxxxxxxxxxxxxx, varenet@xxxxxxxxxxxxxxxx, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>, Netdev <netdev@xxxxxxxxxxx>|
|References:||<200505101955.j4AJtX9x032464@xxxxxxxxxxxxxxxxxxx> <42881C58.40001@xxxxxxxxx> <20050516050843.GA20107@xxxxxxxxxxxxxxx> <4288CE51.1050703@xxxxxxxxx> <20050516222612.GD9282@xxxxxxxxxxxxxxx>|
|User-agent:||Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050328 Fedora/1.7.6-1.2.5|
Grant Grundler wrote:
After three years of using/maintaining the (trivial) tulip patch in parisc-linux tree (and shipped with RH/SuSe ia64 releases), I don't recall anyone complaining that udelays in tulip phy reset caused them problems. Sorry, I'm unmotivated to revisit this. Convince someone else to make tulip to use workqueues and I'll resubmit a clean patch on top of that for the phy init sequences.
Long delays are unacceptable in new drivers, and we are working to remove them from older drivers. Lack of complaints is irrelevant -- its a design requirement of all drivers.
Ingo and the real-time crowd are fighting against every delay, because every delay causes a spin, a blip in latency, an increase in CPU usage, and a complete stoppage of ALL work on a uniprocessor machine.
Your patch is not a special case. We have been communicating this message on udelay/mdelay for -years-. All your patch [as-is] does is cause more work for someone else.
This also presents a problem that Andrew points out on occasion:what happens when a patch is useful, but the patch author isn't (for whatever reason) doing the legwork necessary to get it into the mainline kernel? We certainly DON'T want to lose this patch, as the changes are useful.
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: [PATCH] [BRIDGE] Set features based on slave's ones (was Ethernet Bridging: Enable Hardware Checksumming), Jon Mason|
|Next by Date:||Re: patch tulip-natsemi-dp83840a-phy-fix.patch added to -mm tree, Francois Romieu|
|Previous by Thread:||Re: patch tulip-natsemi-dp83840a-phy-fix.patch added to -mm tree, Grant Grundler|
|Next by Thread:||Re: patch tulip-natsemi-dp83840a-phy-fix.patch added to -mm tree, Francois Romieu|
|Indexes:||[Date] [Thread] [Top] [All Lists]|