|To:||Linus Torvalds <torvalds@xxxxxxxx>|
|Subject:||Re: [PATCH] forcedeth: fix random memory scribbling bug|
|From:||Jeff Garzik <jgarzik@xxxxxxxxx>|
|Date:||Sat, 24 Dec 2005 14:58:26 -0500|
|Cc:||Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>, Ayaz Abdulla <AAbdulla@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Netdev <netdev@xxxxxxxxxxx>|
|User-agent:||Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929)|
Linus Torvalds wrote:
However, that "skb->end - skb->data"calculation is a bit strange. It correctly maps the whole skb, but
wouldn't it make more sense to use the length we actually tell the card to use? In other words, wouldn't it be a whole lot more sensible and logical to usenp->rx_buf_szinstead? That's the value we use for allocation and that's the size we tell the card we have.
That's the sort of thing I prefer.
Of course, on the alloc path, it seems to add an additional "NV_RX_ALLOC_PAD" thing, so maybe the "end-data" thing makes sense.
None of the other ethernet drivers do 'end - data', which is why I hesitated quite a bit on this change.
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: [PATCH] forcedeth: fix random memory scribbling bug, Linus Torvalds|
|Next by Date:||Re: [PATCH] forcedeth: fix random memory scribbling bug, Linus Torvalds|
|Previous by Thread:||Re: [PATCH] forcedeth: fix random memory scribbling bug, Jeff Garzik|
|Indexes:||[Date] [Thread] [Top] [All Lists]|