On Sat, 10 Apr 2010 07:15:50 +1000, Ken McDonell wrote:
kenj> Yep, pretty close to my patch (no man page from me either) ... I just
kenj> went for the -H as a flag, rather than -H hostname (which is the same as
kenj> -h hostname, unless hostname happens to be localhost).
I can live with H being a flag, but I really like to remove
gethostbyname from GetPort - it's just another place where pmlogger is
trying to second-guess user's input and yet another place when it can
kenj> But more importantly your source and mine don't match without the
kenj> patch ... I don't have archive_host in my source, it uses local
kenj> there and there is no second test for pmcd_host being NULL, no strncmp()
kenj> in an else branch ... ???
That's because patch was on top of the earlier change I've made which is
It includes using different names for __pmLogCreate() and for the
pmNewConext and not trying to resolve the name when creating a map
And strncmp is a brain-fart - I'm surpised that the stuff works.