xfs
[Top] [All Lists]

Re: race in unmount code.

To: "Andi Kleen" <ak@xxxxxxx>
Subject: Re: race in unmount code.
From: Daniel Moore <dxm@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 12 May 2000 11:49:37 +1000
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: Your message of "Wed, 10 May 2000 10:57:54 +0200." <20000510105753.A30364@gruyere.muc.suse.de>
Sender: owner-linux-xfs@xxxxxxxxxxx
"Andi Kleen" writes:

 => The vfsmnt stuff is very new in linux -- it was introduced only a few
 => patchlevels before the XFS kernel branched. So it is entirely possible
 => that the generic code is buggy. Maybe this patch will help:
 => 
 => --- linux/fs/super.c-o      Mon Mar 27 20:31:13 2000
 => +++ linux/fs/super.c        Wed May 10 10:58:32 2000
 => @@ -384,6 +384,8 @@
 =>     if (!buffer) return 0;
 =>     for (tmp = vfsmntlist; tmp && len < PAGE_SIZE - 160;
 =>         tmp = tmp->mnt_next) {
 => +           if (!tmp->mnt_sb || !tmp->mnt_sb->s_root)
 => +                   continue;
 =>             path = d_path(tmp->mnt_sb->s_root, buffer, PAGE_SIZE);
 =>             if (!path)
 =>                     continue;

Thanks Andi, this does the trick. I just had a look at the
2.3.99-pre5 release and the same patch is in there.

-----------------------------------------------------
 Daniel Moore                  dxm@xxxxxxx
 R&D Software Engineer         Phone: +61-3-98348209
 SGI Performance Tools Group   Fax:   +61-3-98132378
-----------------------------------------------------


<Prev in Thread] Current Thread [Next in Thread>