xfs
[Top] [All Lists]

Re: nfs fix for test5

To: "Andi Kleen" <ak@xxxxxxx>
Subject: Re: nfs fix for test5
From: Steve Lord <lord@xxxxxxx>
Date: Wed, 27 Sep 2000 09:31:11 -0500
Cc: Thomas Graichen <graichen@xxxxxxxxxxxxx>, thomas.graichen@xxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxx
In-reply-to: Message from "Andi Kleen" <ak@xxxxxxx> of "Wed, 27 Sep 2000 16:22:43 +0200." <20000927162243.A6081@xxxxxxxxxxxxxxxxxxx>
Sender: owner-linux-xfs@xxxxxxxxxxx
> On Wed, Sep 27, 2000 at 02:18:48PM +0000, Thomas Graichen wrote:
> > Index: write.c
> > ===================================================================
> > RCS file: /cvs/linux-2.4-xfs/linux/fs/nfs/write.c,v
> > retrieving revision 1.18
> > diff -u -r1.18 write.c
> > --- write.c 2000/06/02 00:22:59     1.18
> > +++ write.c 2000/09/27 14:06:28
> > @@ -1294,7 +1294,7 @@
> >     struct nfs_page         *req;
> >     struct dentry           *dentry;
> >     struct inode            *inode;
> > -   loff_t                  start, end, len;
> > +   u64                     start, end, len;
> 
> Looks bogus, loff_t is already 64bits. 
> 
> 
> -Andi

And I am still waiting for the coffee to kick in, but Andi is correct, this 
is already 64 bits, but it is signed, so there may be something in the change,
was there any commentry with the original change?

Steve

p.s. Thomas, looks like I will be in Miami after all.



<Prev in Thread] Current Thread [Next in Thread>