>Hi, thanks for looking into it.
>I originally handled the error as I did because per the ioctl man page,
> Usually, on success zero is returned. A few ioctls use the
> return value as an output parameter and return a nonnegative
> value on success. On error, -1 is returned, and
> errno is set appropriately.
>So, I treated error >= 0 as success.
Ah, that is me who is bad [Thanks for advise].
>So, it looks like BLKGETSIZE64 -is- failing* for you, and your patch below
>is really a workaround for this. It might be good to find out why
>the ioctl is failing (which is really not an xfs problem per se)
It actually failed for 32bits release of hppa kernel because BLKGETSIZE64
is not yet implemented; in that case (see linux/include/asm-parisc/uaccess.h)
the kernel printk a BUG message (see syslog) without returning error code
(this should be -1 and not EFAULT as I wrongly assume :( )
>What kind of device are you trying to mkfs on?
Firstly on a simple slice of a scsi disk (It seems to works fine with mentionned
Just still have to test over an evms lvm (which seems also supported as I
read on your ml and code :) )
Thanks again for attention and adivses (just still have to review a hppa