On Sun, 19 Oct 2003 23:31:51 -0800, Ethan Benson wrote:
> Recently my patches to add file flags to XFS were merged (immutable,
> append-only etc). xfsdump has some problems with the new flags:
> What I have done to fix the above problems in order:
Thanks for your work Ethan. Although I've not looked your code, it sounds
like you're doing the right sort of thing.
> * dump/inomap.c: Add warning when SGI_XFSDUMP_SKIP_FILE xattr is
> present, but still honor it, this attribute is deprecated in favor of
> the new nodump file flag, support for the obsolete xattr should be
> removed in a future xfsdump (its not that old so this shouldn't be
> much of a problem). Add check for new nodump file flag.
The SKIP_FILE attribute is still the supported mechanism in IRIX,
therefore it'd be a good idea to keep support for it in the Linux version.
It doesn't hurt performance, so I don't see any reason to remove it.
And since this is still a valid method of skipping files that wouldn't be
removed from xfsdump, issuing a warning is probably the wrong thing to do.
I think perhaps modifying the man page to mention that there is a
preferred alternative to the SKIP_FILE attribute would be appropriate.