xfs
[Top] [All Lists]

Re: typo in XFS_IOC_GETXFLAGS?

To: Nathan Scott <nathans@xxxxxxx>
Subject: Re: typo in XFS_IOC_GETXFLAGS?
From: Herbert Poetzl <herbert@xxxxxxxxxxxx>
Date: Tue, 4 May 2004 12:56:30 +0200
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <20040504123233.D149002@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <20040503215840.GA26617@xxxxxxxxxxxxxxxxx> <20040504085546.B127559@xxxxxxxxxxxxxxxxxxxxxxxx> <20040503230042.GA27312@xxxxxxxxxxxxxxxxx> <20040504123233.D149002@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Tue, May 04, 2004 at 12:32:34PM +1000, Nathan Scott wrote:
> Hi Herbert,
> 
> On Tue, May 04, 2004 at 01:00:42AM +0200, Herbert Poetzl wrote:
> > On Tue, May 04, 2004 at 08:55:46AM +1000, Nathan Scott wrote:
> > > On Mon, May 03, 2004 at 11:58:41PM +0200, Herbert Poetzl wrote:
> > > > 
> > > > xfs_ioc_xattr() uses in XFS_IOC_GETXFLAGS the
> > > > XFS_XFLAG_* defines for di_flags comparison, 
> > > > shouldn't that be XFS_DIFLAG_IMMUTABLE and 
> > > > friends instead?
> > > > 
> > > Yep, good catch - thanks.
> > 
> > well, stumbled over another one ... this
> > actually needs a little additional code ...
> 
> Actually, it turns out that both of these are fine (thought
> I tested this!) because the XFS_XFLAG and XFS_DIFLAG values

well, never said that it wouldn't work ;)

> are the same.  Still, its pretty confusing - I'll clear it
> up in the code.

okay, thanks ...

best,
Herbert

PS: is there some documentation about the XFS 
quota code, I'd like to extend the quota system
by allowing more than one quota hash for each
filesystem (vfsmount)

> cheers.
> 
> -- 
> Nathan


<Prev in Thread] Current Thread [Next in Thread>