xfs
[Top] [All Lists]

Re: xfs oops (CVS-2004-05-15_05:00_UTC)

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: xfs oops (CVS-2004-05-15_05:00_UTC)
From: Krzysztof Rusocki <kszysiu@xxxxxxxxxxxxxxxxxxxx>
Date: Thu, 24 Jun 2004 15:57:22 +0200
Cc: Nathan Scott <nathans@xxxxxxx>, linux-xfs@xxxxxxxxxxx
In-reply-to: <20040624121441.GA9419@xxxxxxxxxxxxx>
References: <20040621021505.GA1173@frodo> <20040621025905.GA1323@xxxxxxxxxxxxxxxxxxxx> <20040621072906.GD1656@frodo> <20040622082906.GA2093@frodo> <20040623084922.GD1323@xxxxxxxxxxxxxxxxxxxx> <20040623203639.A1670881@xxxxxxxxxxxxxxxxxxxxxxxx> <20040623131611.GE1323@xxxxxxxxxxxxxxxxxxxx> <20040624024320.GB5866@frodo> <20040624114608.GF1323@xxxxxxxxxxxxxxxxxxxx> <20040624121441.GA9419@xxxxxxxxxxxxx>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Thu, Jun 24, 2004 at 01:14:41PM +0100, Christoph Hellwig wrote:
> > - current CVS without 1.1371.750.18 _and_ undelay changes - no problems
> >   (tested 10 hours)

Ugh, this ^^^ seems to be no longer accurate. I'm guessing that
these changes are not neccessarily to blame then (wild guess).

> > - current CVS without 1.1371.750.18, 1.1587.5.6 1.1722.10.100 and undelay
> >   changes - no problems (tested 14 hours) (*)

I'll test (*) again and vanilla 2.6.4 (as Nathan suggested)...

>  
> +     ASSERT(list_empty(&pb->pb_list));
>       ASSERT(list_empty(&bp->pb_hash_list));
> +     ASSERT(!(bp->pb_flags & PBF_DELWRI));

For the record: I changed these assertions to BUG_ON(! )s
(as in Nathan's patch) since I do not have CONFIG_XFS_DEBUG
(afaics these assertions are not enabled until CONFIG_XFS_DEBUG
is set).

But... no, these BUG_ONs were not triggered, and oops did happen.


Krzysztof


<Prev in Thread] Current Thread [Next in Thread>