Fix accidental reverting of sync write preallocations.
Date: Mon Aug 2 21:06:25 PDT 2004
Inspected by: felixb@xxxxxxx,cw@xxxxxxxx
The following file(s) were checked into:
xfs_iomap.h - 1.4
xfs_iomap.c - 1.30
linux-2.6/xfs_aops.c - 1.78
linux-2.4/xfs_aops.c - 1.84
rom owner-linux-xfs Tue Aug 3 11:32:04 2004
Received: with ECARTIS (v1.0.0; list linux-xfs); Tue, 03 Aug 2004 11:32:10
Received: from ishtar.tlinx.org (ishtar.tlinx.org [220.127.116.11])
by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i73IW3QE010475
for <linux-xfs@xxxxxxxxxxx>; Tue, 3 Aug 2004 11:32:04 -0700
Received: from [192.168.3.20] (shiva [192.168.3.20])
by ishtar.tlinx.org (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id
Tue, 3 Aug 2004 11:31:54 -0700
Date: Tue, 03 Aug 2004 11:31:53 -0700
From: L A Walsh <lkml@xxxxxxxxx>
User-Agent: Mozilla Thunderbird 0.7.1 (Windows/20040626)
X-Accept-Language: en-us, en
To: Nathan Scott <nathans@xxxxxxx>
CC: linux-kernel@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxx
Subject: Re: XFS: how to NOT null files on fsck?
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=UTF-8; format=flowed
X-ecartis-version: Ecartis v1.0.0
On 07-28-04 Nathan Scott blissfully wrote:
>On Fri, Jul 09, 2004 at 09:37:48AM -0700, L A Walsh wrote:
>>It's a feature! :-)
>>It's been in the code for years to randomly write nulls to some files
The above was meant somewhat tongue-in-cheek, ya know...
> The problem relates to an updated inode size
>being flushed ahead of the data behind it (hence a size update
>can make it out before delayed allocate extents do, and we end
>up with a hole beyond the end of file, which reads as zeroes).
I believe I understand the scenario you are talking about, but I don't
think it fits the examples I have referred to. In particular, "/etc/fstab".
I update 'fstab' on Tuesday, say, it works fine...gets backed up just
fine...and I forget about it and move on. Then, 2-3 days later, my
system crashes and doesn't want to some up. That's odd, usually after
a crash, it just burps a bit and comes back up. I grumble and go for
single user. Turns out my 1.2k fstab file is all "nulls". Coinidentally,
I find, _maybe_, a couple of other files written around the same time,
also nulled, including times when the nulls appeared in the system log
for that time period!
Now I know it takes a while before data may end up on disk and that it
may not go out to disk in an ordered fashion, but 2-3 days? This isn't
a case of a multi-extent file. My current fstab is only 1335 bytes long.
I doubt it has ever been more than 2.
My filesystems all use the Allocation unit (AU) size allowed. I wish
for something larger than a 4k AU size but I'm told it is limited by
the linux page size and to find a PC that uses the IA64 page size to
use larger file AU size (but I haven't seen to many of these IA64 machines
available from Dell or Gateway...:-) Maybe the code in FAT32 that handles
larger AU's could be ported to XFS? If FAT32 can do it...nevermind...
I'm sure there are more important issues on the plate.
>>Apparently not easily reproduced, no one has a clue why it does it.
>No, its actually well known why it behaves this way.
>We are looking into ways to address this, and have some
>ideas - the trick is fixing it without hurting write
>performance - which we will do, its just not trivial.
You could increase the max AU size :-) But more seriously, is my
example of writing a 1 AU sized file that becomes zeroed days later
an example of the problem you are speaking of?
>There are several techiques to reduce the impact of this
>behaviour, as others have described (or see the linux-xfs
Like setting the disk for synchronous writes? Why not something
in between, like guaranteeing the info on a mostly quiescent machine
will be written to disk within an hour or so? Or is that not "it"?
I haven't seen an incidence of this behavior in several months on
my machines so my particular problem may have been fixed and the
problem you speak of is unrelated to my own, but the number of unplanned
shutdowns on my system has only increased recently, since I upgraded
to the stable 2.6 series, whereas before, with 2.4, it could be months
between "blue screens".
Sad was the day that it was decided that the linux-kernel "corp" decided
on feature development vs. stability in the "stable" kernel series.
Isn't that criticism lodged most often against MS. It seems most
incorporated or not, seem to follow similar growth patterns. Wasn't
there an Eastern saying about choosing your enemies wisely for you
will eventually become like them?