On Thu, Sep 08, 2005 at 10:35:00AM -0400, Craig Rodrigues wrote:
> On Thu, Sep 08, 2005 at 09:09:13AM -0500, Steve Lord wrote:
> > If someone converts all the code to plain macros, I suggest you look
> > carefully at the ones which default to being functions, these are
> > probably the main culprits when it comes to code bloat. With today's
> > fast cpus, keeping them as functions might still be worth while
> > from a code size point of view.
> Well, this type of code cleanup is probably a good thing to do,
> but is not what I want to tackle yet for my short-term goal
> of getting xfs_macros.c to compile without warning if
> -Wmissing-prototypes is added to the gcc flags (as is done
> during a FreeBSD kernel build).
But we're not really looking for half-backed things. -Wmissing-prototypes
is a rather stupid warnings extension, and if you care for it you'll have
to deal with it in your tree. If you on the other hands do a cleanup that
fixes your problems as side-effects that's of course fine.