On Mon, Mar 06, 2006 at 11:03:50AM +1100, Nathan Scott wrote:
> [Bunch of stuff, all over the map, to help reduce our stack use]
> Dynamically allocate local kiocb structures in readv/writev routines to
> reduce stack footprint.
> Date: Fri Mar 3 14:18:51 AEDT 2006
> Workarea: chook.melbourne.sgi.com:/build/nathans/xfs-linux
> Inspected by: cattelan,sandeen
> The following file(s) were checked into:
Please don't push this to mainline. The static kiocb will go away soon and
this just causes unessecary churn.
> Dynamically allocate vattr in places it makes sense to do so, to reduce stack
> use. Also re-use vattr in some places so that multiple copies are not held
Please don't. The vattr is small enough to allocate it on the stack. If that's
not enough I have some patches lying around to decrease it's size further.
That's much better than requiring a dynamic allocation in all these places.
> Reduce stack usage within xfs_bmapi by rearranging some code, splitting
> realtime/btree allocators apart. Based on Glens original patches.
whee, that's a pretty nice cleanup.