xfs
[Top] [All Lists]

Re: [RFC] Badness in __mutex_unlock_slowpath with XFS stress tests

To: Nathan Scott <nathans@xxxxxxx>
Subject: Re: [RFC] Badness in __mutex_unlock_slowpath with XFS stress tests
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 9 Mar 2006 22:42:19 +0000
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Suzuki <suzuki@xxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, "linux-aio kvack.org" <linux-aio@xxxxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>, suparna <suparna@xxxxxxxxxx>, akpm@xxxxxxxx, linux-xfs@xxxxxxxxxxx
In-reply-to: <20060309223042.GC1135@frodo>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Nathan Scott <nathans@xxxxxxx>, Suzuki <suzuki@xxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, "linux-aio kvack.org" <linux-aio@xxxxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>, suparna <suparna@xxxxxxxxxx>, akpm@xxxxxxxx, linux-xfs@xxxxxxxxxxx
References: <440FDF3E.8060400@xxxxxxxxxx> <20060309120306.GA26682@xxxxxxxxxxxxx> <20060309223042.GC1135@frodo>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Fri, Mar 10, 2006 at 09:30:42AM +1100, Nathan Scott wrote:
> Not for reads AFAICT - __generic_file_aio_read + own-locking
> should always have released i_mutex at the end of the direct
> read - are you thinking of writes or have I missed something?

if an error occurs before a_ops->direct_IO is called __generic_file_aio_read
will return with i_mutex still locked.  Note that checking for negative
return values is not enough as __blockdev_direct_IO can return errors
aswell.


<Prev in Thread] Current Thread [Next in Thread>