On Mon, Jun 19, 2006 at 12:44:58AM -0700, Avuton Olrich wrote:
> Hello, when trying to recursively delete a directory (same directory
> twice) from my 500gb hard drive I get a problem. It crashed first in
> 184.108.40.206, then I upgraded to try to get rid of the issue. This one is
> from 2.6.17:
How reproducible is it? Is it reproducible even after xfs_repair?
If so, can you try Mandy's patch below, to see if it is addressing
the root cause of your problem? If problems persist, a reproducible
test case would be wonderful, if one can be found..
Fix nused counter. It's currently getting set to -1 rather than getting
decremented by 1. Since nused never reaches 0, the "if (!free->hdr.nused)"
check in xfs_dir2_leafn_remove() fails every time and xfs_dir2_shrink_inode()
doesn't get called when it should. This causes extra blocks to be left on
an empty directory and the directory in unable to be converted back to
inline extent mode.
Signed-off-by: Mandy Kirkconnell <alkirkco@xxxxxxx>
Signed-off-by: Nathan Scott <nathans@xxxxxxx>
--- a/fs/xfs/xfs_dir2_node.c 2006-06-20 16:00:45.000000000 +1000
+++ b/fs/xfs/xfs_dir2_node.c 2006-06-20 16:00:45.000000000 +1000
@@ -972,7 +972,7 @@ xfs_dir2_leafn_remove(
* One less used entry in the free table.
- free->hdr.nused = cpu_to_be32(-1);
+ be32_add(&free->hdr.nused, -1);
* If this was the last entry in the table, we can