xfs
[Top] [All Lists]

Re: [PATCH 1/2] Make stuff static

To: David Chinner <dgc@xxxxxxx>
Subject: Re: [PATCH 1/2] Make stuff static
From: Nathan Scott <nscott@xxxxxxxxxx>
Date: Tue, 17 Oct 2006 13:18:04 +1000
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, Russell Cattelan <cattelan@xxxxxxxxxxx>, Timothy Shimmin <tes@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20061017030908.GP11034@xxxxxxxxxxxxxxxxx>
Organization: Aconex
References: <20060929032856.8DA9C18001A5E@xxxxxxxxxxx> <23F15D6AE8566A54B81188AC@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <45338DDE.8020903@xxxxxxxxxxx> <4533FAEA.2080500@xxxxxxxxxxx> <20061016232250.GM11034@xxxxxxxxxxxxxxxxx> <1161042943.5723.117.camel@xxxxxxxxxxxxxxxxxxxx> <20061017005038.GN11034@xxxxxxxxxxxxxxxxx> <45342BF3.8020609@xxxxxxxxxxx> <20061017030908.GP11034@xxxxxxxxxxxxxxxxx>
Reply-to: nscott@xxxxxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
On Tue, 2006-10-17 at 13:09 +1000, David Chinner wrote:
> On Mon, Oct 16, 2006 at 08:03:47PM -0500, Eric Sandeen wrote:
> > David Chinner wrote:
> > 
> Of course, no plan ever survives contact with the enemy. :/
> 
> STATIC is also used for defining various structure tables.
> And variables.  They'll all get changed to "static"....
> 
> Then there's __inline and __inline__ still used in places.....
> 
> The patch that follows does the noinline change, de-inlines
> xfs_cleanup_inode() and cleans up all the inline cruft hanging around.
> 
> Comments?
> 

Be careful of userspace, where much of this code is also compiled in
libxfs, and STATIC is always #defined away to nothingness there (as
there's need for some routines to be accessed outside of one source
file there, differently to the kernel, IIRC).

cheers.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>