xfs
[Top] [All Lists]

Re: [PATCH] fix bad quota inodes in the superblock causing xfs_repair to

To: Barry Naujok <bnaujok@xxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] fix bad quota inodes in the superblock causing xfs_repair to crash
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 20 Feb 2007 08:35:32 -0600
Cc: xfs@xxxxxxxxxxx, xfs-dev@xxxxxxxxxxxx
In-reply-to: <200702200753.SAA18328@xxxxxxxxxxxxxxxxxxxxxxx>
References: <200702200753.SAA18328@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.9 (Macintosh/20061207)
Barry Naujok wrote:
Thanks to Eric for generating bad images with fsfuzzer, bad quota inode
values in the superblock caused xfs_repair to segfault. The patch checks the
validity of the inodes before doing an internal lookup which assumes the
numbers are valid before being called.


Looks good to me Barry, thanks! I'll see if I can find more corrupt images for you. ;-)

-Eric


<Prev in Thread] Current Thread [Next in Thread>