xfs
[Top] [All Lists]

Re: Review: factor extracting extent size hints from the inode

To: David Chinner <dgc@xxxxxxx>
Subject: Re: Review: factor extracting extent size hints from the inode
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 4 Jun 2007 16:10:34 +0100
Cc: xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20070604052333.GR85884050@xxxxxxx>
References: <20070604052333.GR85884050@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.2i
On Mon, Jun 04, 2007 at 03:23:33PM +1000, David Chinner wrote:
> Replace frequently repeated, open coded extraction of the
> extent size hint from the xfs_inode with a single helper
> function.

Looks good, but I'd suggest not putting in the unlikelys.  Realtime
or alignment are perfectly normal codepaths and hardcoding them to
be predicted not taken sounds like a bad idea.  unlilely should be
limited to exception error handling code.


<Prev in Thread] Current Thread [Next in Thread>