xfs
[Top] [All Lists]

Re: [PATCH] use filldir internally

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH] use filldir internally
From: David Chinner <dgc@xxxxxxx>
Date: Fri, 8 Jun 2007 09:27:16 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20070604143958.GB9081@xxxxxx>
References: <20070604143958.GB9081@xxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Mon, Jun 04, 2007 at 04:39:58PM +0200, Christoph Hellwig wrote:
> Currently xfs has a rather complicated internal scheme to allow for
> different directory formats in IRIX.  This patch rips all code related
> to this out and pushes useage of the Linux filldir callback into the
> lowlevel directory code.  This does not make the code any less portable
> because filldir can be used to create dirents of all possible variations
> (including the IRIX ones as proved by the IRIX binary emulation code
> under arch/mips/).
> 
> This patch get rid of an unessecary copy in the readdir path, about
> 250 lines of code and one of the last two users of the uio structure.

Looks like a nice cleanup at a quick glance, but I need to spend more time
looking at it which I don't have right now. I'll add it to my QA in the
meantime....

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group


<Prev in Thread] Current Thread [Next in Thread>