[Top] [All Lists]

Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume

To: Pavel Machek <pavel@xxxxxx>
Subject: Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume
From: David Chinner <dgc@xxxxxxx>
Date: Fri, 29 Jun 2007 14:55:53 +1000
Cc: David Chinner <dgc@xxxxxxx>, David Greaves <david@xxxxxxxxxxxx>, David Robinson <zxvdr.au@xxxxxxxxx>, LVM general discussion and development <linux-lvm@xxxxxxxxxx>, "'linux-kernel@xxxxxxxxxxxxxxx'" <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-pm <linux-pm@xxxxxxxxxxxxxx>, LinuxRaid <linux-raid@xxxxxxxxxxxxxxx>
In-reply-to: <20070627204924.GA4777@xxxxxx>
References: <46744065.6060605@xxxxxxxxxxxx> <4674645F.5000906@xxxxxxxxx> <46751D37.5020608@xxxxxxxxxxxx> <4676390E.6010202@xxxxxxxxxxxx> <20070618145007.GE85884050@xxxxxxx> <20070627204924.GA4777@xxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/
On Wed, Jun 27, 2007 at 08:49:24PM +0000, Pavel Machek wrote:
> Hi!
> > FWIW, I'm on record stating that "sync" is not sufficient to quiesce an XFS
> > filesystem for a suspend/resume to work safely and have argued that the only
> Hmm, so XFS writes to disk even when its threads are frozen?

They issue async I/O before they sleep and expects
processing to be done on I/O completion via workqueues.

> > safe thing to do is freeze the filesystem before suspend and thaw it after
> > resume. This is why I originally asked you to test that with the other 
> > problem
> Could you add that to the XFS threads if it is really required? They
> do know that they are being frozen for suspend.

We don't suspend the threads on a filesystem freeze - they continue
run. A filesystem freeze guarantees the filesystem clean and that
the in memory state matches what is on disk. It is not possible for
the filesytem to issue I/O or have outstanding I/O when it is in the
frozen state, so the state of the threads and/or workqueues does not
matter because they will be idle.


Dave Chinner
Principal Engineer
SGI Australian Software Group

<Prev in Thread] Current Thread [Next in Thread>