[Top] [All Lists]

Re: REVIEW: fix xfs_bmap -vp confusion

To: "David Chinner" <dgc@xxxxxxx>
Subject: Re: REVIEW: fix xfs_bmap -vp confusion
From: "Barry Naujok" <bnaujok@xxxxxxx>
Date: Wed, 11 Jul 2007 16:04:05 +1000
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>
In-reply-to: <20070711055347.GP12413810@xxxxxxx>
Organization: SGI
References: <op.tu954us03jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20070711055347.GP12413810@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Opera Mail/9.10 (Win32)
On Wed, 11 Jul 2007 15:53:47 +1000, David Chinner <dgc@xxxxxxx> wrote:

On Wed, Jul 11, 2007 at 01:18:20PM +1000, Barry Naujok wrote:
If xfs_bmap -vp is run on a file without unwritten extents
and the filesystem does not use sunit/swidth, the FLAGS
column is not shown. This leads to some confusion.

So, when -vp option is used, it will always print the
FLAGS column.

I note that it only prints the legend if a flag is set. I guess
this is ok, but maybe it would be more consistent to always
print the legend? Or even to make the legend optional (which
would make dumping more than one file more compact)?



The legend* is only shown with an extra -v option and the FLAGS
column displayed. The updated man pages posted out yesterday
documents this.

* I assume the legend you refer to is:
 FLAG Values:
    010000 Unwritten preallocated extent
    001000 Doesn't begin on stripe unit
    000100 Doesn't end   on stripe unit
    000010 Doesn't begin on stripe width
    000001 Doesn't end   on stripe width

<Prev in Thread] Current Thread [Next in Thread>