xfs
[Top] [All Lists]

Re: [PATCH] refactor xfs_mountfs for clarity & stack savings

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] refactor xfs_mountfs for clarity & stack savings
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 28 Aug 2007 20:52:21 +0100
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <46D37A82.2080608@xxxxxxxxxxx>
References: <46D37A82.2080608@xxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.3i
Looks goo to me except for a tiny nitpick:

> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx
> +             if ((error = xfs_readsb(mp, mfsi_flags))) {
> +                     return error;
> +             }

> +     if ((error = xfs_update_alignment(mp, mfsi_flags, &update_flags)))
> +             goto error1;

> +     if ((error = xfs_check_sizes(mp, mfsi_flags)))
> +             goto error1;

>       if ((error = xfs_rtmount_init(mp))) {

Please make sure the assignment and conditional are on separate lines
for all of these once you're cleaning up this function.  In the first
case there's also some braces to remove.


<Prev in Thread] Current Thread [Next in Thread>