xfs
[Top] [All Lists]

Re: [PATCH] lose xfs_hex_dump in favor of print_hex_dump

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] lose xfs_hex_dump in favor of print_hex_dump
From: Chris Wedgwood <cw@xxxxxxxx>
Date: Mon, 24 Sep 2007 17:32:32 -0700
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <46F85240.1060206@xxxxxxxxxxx>
References: <46F85240.1060206@xxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
On Mon, Sep 24, 2007 at 07:11:44PM -0500, Eric Sandeen wrote:

> +extern void xfs_hex_dump(void *p, int length);
> +

> +void
> +xfs_hex_dump(void *p, int length)
> +{
> +     print_hex_dump(KERN_ALERT, "", DUMP_PREFIX_OFFSET, 16, 1, p, length, 1);
> +}

Is this symbol exported/needed?  If not then why not make it a #define
or an inline in the header where you have the prototype?


<Prev in Thread] Current Thread [Next in Thread>