xfs
[Top] [All Lists]

Re: [PATCH] fix dir2 shortform structures on ARM old ABI

To: Andre Draszik <xfs@xxxxxxxxxx>
Subject: Re: [PATCH] fix dir2 shortform structures on ARM old ABI
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 19 Mar 2008 00:31:09 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <47E0A07D.5090803@sandeen.net>
References: <b1b17e290803181631x60a3e921l836b115c3b026773@mail.gmail.com> <47E085F3.8030908@sandeen.net> <47E0A07D.5090803@sandeen.net>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.12 (Macintosh/20080213)
Eric Sandeen wrote:
> Eric Sandeen wrote:
> 
>> I've helpfully provided structure layouts for the structures you mention
>> in the attached files, for your diffing pleasure.  I think you'll find
>> that it's not exactly as you described.
> 
> Ah hell the arm structs I attached were for oldabi.  It's what I get for
> saving this fun work for late at night ;)
> 
> Attached are eabi structs; still only xfs_dir2_data_entry, xfs_dinode
> and xfs_log_item seem to be affected by end-of-struct padding, of the
> structures you mention.  And xfs_log_item isn't a disk structure...
> 
> which brings me back to, what specific failures do you see as a result
> of end-of-struct padding on these structs?

... especially since the layout is identical to ia64, padding and all!

Ok must.. stop.. replying.. to.. self.

-Eric


<Prev in Thread] Current Thread [Next in Thread>