xfs
[Top] [All Lists]

Re: [PATCH] xfsqa: call _notrun in common.dump if dump utils not found

To: Chris Wedgwood <cw@xxxxxxxx>
Subject: Re: [PATCH] xfsqa: call _notrun in common.dump if dump utils not found
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 23 Mar 2008 15:29:55 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20080323054136.GA7529@puku.stupidest.org>
References: <47E5CFBA.7060405@sandeen.net> <20080323054136.GA7529@puku.stupidest.org>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.12 (Macintosh/20080213)
Chris Wedgwood wrote:
> On Sat, Mar 22, 2008 at 10:34:18PM -0500, Eric Sandeen wrote:
> 
>> it may not always be obvious to outsiders that xfsdump is packaged
>> separately from xfsprogs... is it worth checking for the binaries
>> rather than spewing verbose failures if it's not installed?
> 
> I really think xfsdump & fsr should be moved to xfsprogs.
> 

wouldn't bother me...

tests should probably require the executable either way :)

-Eric


<Prev in Thread] Current Thread [Next in Thread>