xfs
[Top] [All Lists]

Re: [PATCH, RFC] fix attr fit checking for filesystems which have lost t

To: Timothy Shimmin <tes@xxxxxxx>
Subject: Re: [PATCH, RFC] fix attr fit checking for filesystems which have lost their attr2
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 30 Mar 2008 20:45:09 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <47F035E3.1030004@xxxxxxx>
References: <47EDCBF9.4070102@xxxxxxxxxxx> <47F035E3.1030004@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.12 (Macintosh/20080213)
Timothy Shimmin wrote:
> Hi Eric,
> 
> Eric Sandeen wrote:
...


>> My understanding of this is that if di_forkoff is non-zero,
>> we should always be using it for space calculations, regardless
>> of whether we are mounted with attr2 or not...
>>
> That was my understanding as well.
> I'll have a look at the code soon and see if I can
> see any problems with the change and the consistency
> of it all.
> 
> Thanks a bunch,
> Tim.

Thanks.  FWIW, if I install F8 with bona-fide attr2 in effect, with
selinux (so attrs on everything) and then update it while mounted as an
attr1 filesystem, with this patch in place, it does not result in
anything bad as far as xfs_repair can see.   (and it's a big update,
probably touching most files...)

-Eric


<Prev in Thread] Current Thread [Next in Thread>