[Top] [All Lists]

Re: [PATCH 5/7] XFS: Unicode case-insensitive lookup implementation

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 5/7] XFS: Unicode case-insensitive lookup implementation
From: Jeremy Allison <jra@xxxxxxxxx>
Date: Thu, 3 Apr 2008 11:22:26 -0700
Cc: Jeremy Allison <jra@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Barry Naujok <bnaujok@xxxxxxx>, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <47F51DDE.8070501@xxxxxxxxxxx>
References: <20080402062508.017738664@xxxxxxxxxxxxxxxxxxxxxxx> <20080402062709.011126702@xxxxxxxxxxxxxxxxxxxxxxx> <20080403171450.GB22385@xxxxxxxxxxxxx> <20080403172400.GC22812@samba1> <47F51DDE.8070501@xxxxxxxxxxx>
Reply-to: Jeremy Allison <jra@xxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.11
On Thu, Apr 03, 2008 at 01:11:42PM -0500, Eric Sandeen wrote:
> Jeremy Allison wrote:
> > On Thu, Apr 03, 2008 at 01:14:50PM -0400, Christoph Hellwig wrote:
> >> Validating file names is not the filesystem job.  In fact it's utterly
> >> stupid, a unix filename is a sequence of bytes without special meaning
> >> except for ., .., / and \0
> > 
> > This patch will be extremely useful for users who are serving
> > Windows clients using Samba. It allow admins to turn off the
> > userspace case insensitivity we have to emulate and be a significant
> > speed increase.
> I'd like to see the numbers... Simo tested an earlier version of this
> patch, and it was not faster.... Jeremy, what would be a representative
> test setup to use?

It very much depends on the usage case. We have many users who have
large numbers of files per directory, and not having to search these
in userspace when we get a stat cache miss is helpful. Just running a
generic "netbench" test won't show any difference, as that test
uses separate directories for each client with small numbers of
files per directory.

There's a reason I wrote this HOWTO (having to use an alternate
link as samba.org seems to be down right now):



<Prev in Thread] Current Thread [Next in Thread>