xfs
[Top] [All Lists]

Re: [PATCH 5/7] XFS: Unicode case-insensitive lookup implementation

To: Jeremy Allison <jra@xxxxxxxxx>
Subject: Re: [PATCH 5/7] XFS: Unicode case-insensitive lookup implementation
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 3 Apr 2008 14:57:17 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Barry Naujok <bnaujok@xxxxxxx>, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20080403185526.GA6045@xxxxxxxxxxxxx>
References: <20080402062508.017738664@xxxxxxxxxxxxxxxxxxxxxxx> <20080402062709.011126702@xxxxxxxxxxxxxxxxxxxxxxx> <20080403171450.GB22385@xxxxxxxxxxxxx> <20080403172400.GC22812@samba1> <20080403184333.GA30595@xxxxxxxxxxxxx> <20080403184739.GB6100@samba1> <20080403185526.GA6045@xxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
On Thu, Apr 03, 2008 at 02:55:26PM -0400, Christoph Hellwig wrote:
> On Thu, Apr 03, 2008 at 11:47:39AM -0700, Jeremy Allison wrote:
> > > CI filenames can work perfectly fine without adding validation of file
> > > names by treating non-conformant bytestreams as not having lower/upper
> > > case variants.
> > 
> > Sorry, then I'm not understanding your objection to this patch (and I
> > don't think I understood that sentence :-).
> 
> I objected to the part of the patch I've quoted (and the bitsrelated to
> it), not all of it.  That how we do reviews in kernel land, not sure
> how samba handles it if you have a binary object/don't object policy..

oops, look like the quote actually got deleted accidentally.  sorry
I'ltake that comment back.

The part I object to are the various calls to xfs_unicode_validate
in the namespace operations.


<Prev in Thread] Current Thread [Next in Thread>