xfs
[Top] [All Lists]

TAKE 979661 - Fix lock inversion in forced shutdown.

To: sgi.bugs.xfs@xxxxxxxxxxxx
Subject: TAKE 979661 - Fix lock inversion in forced shutdown.
From: dgc@xxxxxxx (David Chinner)
Date: Wed, 9 Apr 2008 14:03:21 +1000 (EST)
Cc: xfs@xxxxxxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
Fix lock inversion in forced shutdown.

Recent changes to xlog_state_release_iclog() placed the grant_lock
inside the icloglock. forced unmount of the log does this the opposite
way around, but does not depend on the order for correct working.
Fix the inversion by changing the order locks are gained in
xfs_log_force_umount().


Date:  Wed Apr  9 14:02:59 AEST 2008
Workarea:  chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs
Inspected by:  hch@xxxxxxxxxxxxx

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:30773a
fs/xfs/xfs_log.c - 1.353 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_log.c.diff?r1=text&tr1=1.353&r2=text&tr2=1.352&f=h
        - Fix lock inversion in forced shutdown.



<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 979661 - Fix lock inversion in forced shutdown., David Chinner <=