[Top] [All Lists]

TAKE 979416 - Don't initialise new inode generation numbers to zero

To: sgi.bugs.xfs@xxxxxxxxxxxx
Subject: TAKE 979416 - Don't initialise new inode generation numbers to zero
From: dgc@xxxxxxx (David Chinner)
Date: Tue, 29 Apr 2008 10:41:44 +1000 (EST)
Cc: xfs@xxxxxxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
Don't initialise new inode generation numbers to zero

When we allocation new inode chunks, we initialise the generation
numbers to zero. This works fine until we delete a chunk and then
reallocate it, resulting in the same inode numbers but with a
reset generation count. This can result in inode/generation
pairs of different inodes occurring relatively close together.

Given that the inode/gen pair makes up the "unique" portion of
an NFS filehandle on XFS, this can result in file handles cached
on clients being seen on the wire from the server but refer to
a different file. This causes .... issues for NFS clients.

Hence we need a unique generation number initialisation for
each inode to prevent reuse of a small portion of the generation
number space. Use a random number to initialise the generation
number so we don't need to keep any new state on disk whilst
making the new number difficult to guess from previous allocations.

Date:  Tue Apr 29 10:41:26 AEST 2008
Workarea:  chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs
Inspected by:  hch@xxxxxxxxxxxxx

The following file(s) were checked into:

Modid:  xfs-linux-melb:xfs-kern:31001a
fs/xfs/xfs_ialloc.c - 1.199 - changed
        - use random32() to initialise the generation in newly allocated
          inodes to prevent short term reuse of inode,gen pairs which
          can cause ESTALE problems for NFS clients.

<Prev in Thread] Current Thread [Next in Thread>