On Mon, May 26, 2008 at 11:43:42AM +1000, Timothy Shimmin wrote:
> I guess this is done to some extent by the put_listent() callback.
> Though, the context structure is probably a bit overused in different
> The callback was also used for searching (for parent-ptr code) as well
> as for list formatting.
> I presume we are preserving the valuelen list format to keep the API
> for xfs_attrlist_by_handle used by xfsdump and probably for dmf.
Yes, the idea is to change the put_listen callback for work more like
filldir. Thas is:
- the callback is supplied by the xfs_attr_list caller, not set based
- there will be an opaque object supplied to xfs_attr_list that is to
be used by put_listent so that we don't have to pass down
implementation-specific arguments directly.
I'd also like to move the attrlist_cursor_kern_t into this callback
opaque context because it doesn't make sense for the normal xattr API,
but I'll have to see if that's actually feasible.