xfs
[Top] [All Lists]

Re: [PATCH 1/2] simplify xfs_vn_listxattr

To: Timothy Shimmin <tes@xxxxxxx>
Subject: Re: [PATCH 1/2] simplify xfs_vn_listxattr
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 6 Jun 2008 07:43:47 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4848BFE8.6000205@xxxxxxx>
References: <20080603114837.GB2703@xxxxxx> <4848BFE8.6000205@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Fri, Jun 06, 2008 at 02:41:12PM +1000, Timothy Shimmin wrote:
> Need to fix param type.
> 
> re:
> 
> static int
> list_one_attr(const char *name, const size_t len, void *data,
>                 size_t size, ssize_t *result)
> 
> typedef struct xfs_attr_list_context {
>         struct xfs_inode                *dp;            /* inode */
>         struct attrlist_cursor_kern     *cursor;        /* position in list */
>         char                            *alist;         /* output buffer */
>         int                             seen_enough;    /* T/F: seen enough 
> of list? */
>         int                             count;          /* num used entries */
> 
> => mismatch type on &context.count (int) and list_one_attr's result
> param (ssize_t => long)

Yes, didn't see that on my 32-bit machine :)  count should probably
be ssize_t.


<Prev in Thread] Current Thread [Next in Thread>