xfs
[Top] [All Lists]

TAKE 983508 - attrmulti cleanup

To: sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
Subject: TAKE 983508 - attrmulti cleanup
From: tes@xxxxxxx (Tim Shimmin)
Date: Wed, 25 Jun 2008 10:46:28 +1000 (EST)
Sender: xfs-bounce@xxxxxxxxxxx
xfs_attrmulti_by_handle currently request the size based on
sizeof(attr_multiop_t) but should be using sizeof(xfs_attr_multiop_t)
because that is what it is dealing with.  Despite beeing wrong this
actually harmless in practice because both structures are the same size
on all platforms.

But this sizeof was the only user of struct attr_multiop so we can just
kill it.  Also move the ATTR_OP_* defines xfs_attr.h into the
struct xfs_attr_multiop defintion in xfs_fs.h because they are only used
with that structure, and are part of the user ABI for the
XFS_IOC_ATTRMULTI_BY_HANDLE ioctl.


Signed-off-by: Christoph Hellwig <hch@xxxxxx>


Date:  Wed Jun 25 10:45:34 AEST 2008
Workarea:  chook.melbourne.sgi.com:/build/tes/2.6.x-xfs-quilt
Inspected by:  hch@xxxxxx

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:31352a
fs/xfs/xfs_fs.h - 1.38 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_fs.h.diff?r1=text&tr1=1.38&r2=text&tr2=1.37&f=h
        - attrmulti cleanup

fs/xfs/xfs_attr.h - 1.44 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_attr.h.diff?r1=text&tr1=1.44&r2=text&tr2=1.43&f=h
        - attrmulti cleanup

fs/xfs/linux-2.6/xfs_ioctl.c - 1.167 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_ioctl.c.diff?r1=text&tr1=1.167&r2=text&tr2=1.166&f=h
        - attrmulti cleanup



<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 983508 - attrmulti cleanup, Tim Shimmin <=