xfs
[Top] [All Lists]

Re: [PATCH 05/10] XFS: xfssyncd: don't call xfs_sync

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/10] XFS: xfssyncd: don't call xfs_sync
From: "Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>
Date: Sat, 13 Sep 2008 12:58:56 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1221314230-28618-6-git-send-email-david@xxxxxxxxxxxxx>
References: <1221314230-28618-1-git-send-email-david@xxxxxxxxxxxxx> <1221314230-28618-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sat, Sep 13, 2008 at 11:57:05PM +1000, Dave Chinner wrote:
...
> @@ -533,8 +538,15 @@ xfs_sync_worker(
>  {
>       int             error;
>  
> -     if (!(mp->m_flags & XFS_MOUNT_RDONLY))
> -             error = xfs_sync(mp, SYNC_FSDATA | SYNC_BDFLUSH | SYNC_ATTR);
> +     if (!(mp->m_flags & XFS_MOUNT_RDONLY)) {
> +             xfs_log_force(mp, (xfs_lsn_t)0, XFS_LOG_FORCE);
> +             xfs_finish_reclaim_all(mp, 1, XFS_IFLUSH_DELWRI_ELSE_ASYNC);
> +             /* dgc: errors ignored here */

Again, why?

> +             error = XFS_QM_DQSYNC(mp, SYNC_BDFLUSH);
> +             error = xfs_sync_fsdata(mp, SYNC_BDFLUSH);
> +             if (xfs_log_need_covered(mp))
> +                     error = xfs_commit_dummy_trans(mp, XFS_LOG_FORCE);
> +     }
>       mp->m_sync_seq++;
>       wake_up(&mp->m_wait_single_sync_task);
>  }

Josef 'Jeff' Sipek.

-- 
I'm somewhere between geek and normal.
                - Linus Torvalds

<Prev in Thread] Current Thread [Next in Thread>