xfs
[Top] [All Lists]

Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount

To: Peter Leckie <pleckie@xxxxxxx>, xfs@xxxxxxxxxxx, xfs-dev@xxxxxxx
Subject: Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 29 Sep 2008 17:45:24 -0400
In-reply-to: <20080925010318.GB27997@disturbed>
References: <48D9C1DD.6030607@xxxxxxx> <48D9EB8F.1070104@xxxxxxx> <48D9EF6E.8010505@xxxxxxx> <20080924074604.GK5448@disturbed> <48D9F718.4010905@xxxxxxx> <20080925010318.GB27997@disturbed>
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Sep 25, 2008 at 11:03:18AM +1000, Dave Chinner wrote:
> This is a similar situation - if the sv_t is broken, we need to
> replace all users, not just work around one symptom of the
> brokenness. This is expecially important as the remaining users
> of sv_t's are in the log for iclog synchronisation....

The sv_t is not broken per se but a quite dangerous primitive as
people can easily miss re-checking the condition after a wakeup.

After a quick check 5 out of 10 callers of sv_wait re-check their
condition, and most do in a quite broad loop.  It might make sense
to just that lille bit of code and use prepare_wait / finish_wait
explicitly.

<Prev in Thread] Current Thread [Next in Thread>