xfs
[Top] [All Lists]

[PATCH] fix remount rw with unrecognized options

To: xfs@xxxxxxxxxxx
Subject: [PATCH] fix remount rw with unrecognized options
From: Christoph Hellwig <hch@xxxxxx>
Date: Sun, 12 Oct 2008 14:30:44 +0200
User-agent: Mutt/1.3.28i
When we skip unrecognized options in xfs_fs_remount we should just break
out of the switch and not return because otherwise we may skip clearing
the xfs-internal read-only flag.  This will only show up on some
operations like touch because most read-only checks are done by the VFS
which things this filesystem is r/w.  Eventually we should replace the
XFS read-only flag with a helper that always checks the VFS flag to make
sure they can never get out of sync.

Bug reported and fix verified by Marcel Beister on #xfs.


Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c
===================================================================
--- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_super.c     2008-10-11 
00:59:04.000000000 +0200
+++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c  2008-10-11 00:59:35.000000000 
+0200
@@ -1218,7 +1218,7 @@ xfs_fs_remount(
        "XFS: mount option \"%s\" not supported for remount\n", p);
                        return -EINVAL;
 #else
-                       return 0;
+                       break;
 #endif
                }
        }

<Prev in Thread] Current Thread [Next in Thread>