xfs
[Top] [All Lists]

Re: [PATCH 2/2 v2] hook up fiemap & associated formatter

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 2/2 v2] hook up fiemap & associated formatter
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 25 Oct 2008 16:26:57 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4903207B.6030009@xxxxxxxxxxx>
References: <49031E81.7040807@xxxxxxxxxxx> <4903207B.6030009@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
> +#define XFS_FIEMAP_FLAGS     (FIEMAP_FLAG_SYNC|FIEMAP_FLAG_XATTR)

Why do we need FIEMAP_FLAG_SYNC in here?  That flag is implemented in
the VFS and should be handled there.  (Probably more a question for
the generic implementation than your patch)

> +
> +STATIC int xfs_fiemap_format(

STATIC int
xfs_fiemap_format(



Buit the meat of the patch looks good to me.

<Prev in Thread] Current Thread [Next in Thread>