xfs
[Top] [All Lists]

Re: [PATCH] clean up printk formats with DMAPI_DEBUG

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] clean up printk formats with DMAPI_DEBUG
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sat, 25 Oct 2008 15:27:19 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20081025202005.GC28002@xxxxxxxxxxxxx>
References: <49031BB1.7080609@xxxxxxxxxxx> <20081025202005.GC28002@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.17 (Macintosh/20080914)
Christoph Hellwig wrote:
> On Sat, Oct 25, 2008 at 08:14:25AM -0500, Eric Sandeen wrote:
>>  #ifdef CONFIG_DMAPI_DEBUG
>> -    printk("xfs_dm_round_hole: off %lu, len %ld, align %lu, "
>> -           "filesize %llu, roff %ld, rlen %ld\n",
>> +    printk("xfs_dm_round_hole: off %lld, len %llu, align %llu, "
>> +           "filesize %lld, roff %lld, rlen %llu\n",
>>             offset, length, align, filesize, *roff, *rlen);
> 
> We'd still need casts to (unsigned) long long because the 64 bit
> types may be either variant on 64 bit platforms.
> 

Ah crud you're right, I forgot that s64 was sometimes just a "long"

Bah; is there no format that does this cleanly? :)

-Eric

<Prev in Thread] Current Thread [Next in Thread>