xfs
[Top] [All Lists]

Re: do_sync() and XFSQA test 182 failures....

To: xfs@xxxxxxxxxxx
Subject: Re: do_sync() and XFSQA test 182 failures....
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 31 Oct 2008 16:37:16 -0400
In-reply-to: <20081031004814.GN4985@disturbed>
References: <20081030085020.GP17077@disturbed> <20081030224625.GA18690@xxxxxxxxxxxxx> <20081031001249.GM4985@disturbed> <20081031004814.GN4985@disturbed>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Oct 31, 2008 at 11:48:14AM +1100, Dave Chinner wrote:
> @@ -1118,8 +1118,7 @@ xfs_fs_write_super(
>       struct super_block      *sb)
>  {
>       if (!(sb->s_flags & MS_RDONLY))
> +             xfs_sync_fsdata(XFS_M(sb), SYNC_WAIT);

Not commenting on the rest yet, but I'm sure you noticed that before
your patch we ever called xfs_sync_fsdata with SYNC_WAIT at all.  I
think with the current codebase there is nothing to guarantee we ever
write the superblock out to disk as xfs_wait_buftarg specificly
excludes the superblock (XBF_FS_MANAGED)

<Prev in Thread] Current Thread [Next in Thread>