xfs
[Top] [All Lists]

Re: [patch 07/12] Fix xfs_bulkstat_one size checks & error handling

To: sandeen@xxxxxxxxxxx
Subject: Re: [patch 07/12] Fix xfs_bulkstat_one size checks & error handling
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 26 Nov 2008 05:34:47 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081126032028.571084174@sandeen.net>
References: <20081126032005.639750968@sandeen.net> <20081126032028.571084174@sandeen.net>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Nov 25, 2008 at 09:20:12PM -0600, sandeen@xxxxxxxxxxx wrote:
> The 32-bit xfs_blkstat_one handler was failing because
> a size check checked whether the remaining (32-bit)
> user buffer was less than the (64-bit) bulkstat buffer,
> and failed with ENOMEM if so.  Move this check
> into the respective handlers so that they check the
> correct sizes.
> 
> Also, the formatters were returning negative errors
> or positive bytes copied; this was odd in the positive
> error value world of xfs, and handled wrong by at least
> some of the callers, which treated the bytes returned
> as an error value.  Move the bytes-used assignment
> into the formatters

Looks good.

<Prev in Thread] Current Thread [Next in Thread>